[PATCH] D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 13:41:49 PDT 2019


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

otherwise LGTM



================
Comment at: test/CodeGen/WebAssembly/cfg-stackify-eh.ll:2
 ; RUN: llc < %s -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -disable-block-placement -verify-machineinstrs -fast-isel=false -machine-sink-split-probability-threshold=0 -cgp-freq-ratio-to-skip-merge=1000 -exception-model=wasm -mattr=+exception-handling | FileCheck %s
+; RUN: llc < %s -O0 -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -verify-machineinstrs -fast-isel=false -exception-model=wasm -mattr=+exception-handling | FileCheck %s --check-prefix=NOOPT
 
----------------
Should we remove `-fast-isel=false` from the RUN line? As it is, this doesn't test a common configuration (i.e. O0 but with DAG ISel).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59739/new/

https://reviews.llvm.org/D59739





More information about the llvm-commits mailing list