[PATCH] D59713: [ARM] Add missing memory operands to a bunch of instructions.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 25 12:27:00 PDT 2019
efriedma marked 2 inline comments as done.
efriedma added inline comments.
================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:1180
+ if (MI.mayStore() && hasStoreToStackSlot(MI, Accesses) &&
+ Accesses.size() == 1) {
FrameIndex =
----------------
SjoerdMeijer wrote:
> I can see that this extra check makes sense, just curious how it relates to the other changes.
Without this, the assembly remarks get messed up; instead of "@ 8-byte Folded Spill", we get something like "@ 4-byte Spill" for an instruction that accesses two spill slots.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59713/new/
https://reviews.llvm.org/D59713
More information about the llvm-commits
mailing list