[PATCH] D59284: [NFC][PowerPC] Custom PowerPC specific machine-scheduler

[Jinsong Ji via Phabricator via llvm-commits]

jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM, except for some minor comments change. 
Thanks for extending this, it will allow us to tune MachineScheduler specifically for PowerPC going forward.



================
Comment at: llvm/lib/Target/PowerPC/PPCMachineScheduler.h:1
+
+//===- PPCMachineScheduler.h - Custom PowerPC MI scheduler --*- C++ -*-===//
----------------
Why an empty first line?


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineScheduler.h:21
+
+// A MachineSchedStrategy implementation for PowerPC scheduling.
+class PPCPreRASchedStrategy : public GenericScheduler {
----------------
Maybe add "pre RA" in comment too, as "post RA" in below?


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineScheduler.h:21
+
+// A MachineSchedStrategy implementation for PowerPC scheduling.
+class PPCPreRASchedStrategy : public GenericScheduler {
----------------
jsji wrote:
> Maybe add "pre RA" in comment too, as "post RA" in below?
Doxgen comment instead?  `//' -> `///'


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineScheduler.h:28
+
+// A MachineSchedStrategy implementation for PowerPC post RA scheduling.
+class PPCPostRASchedStrategy : public PostGenericScheduler {
----------------
Doxgen comment instead? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59284/new/

https://reviews.llvm.org/D59284