[PATCH] D59778: AMDGPU: Make exec mask optimzations more resistant to block splits

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: test/CodeGen/AMDGPU/collapse-endcf.mir:146
   ; GCN:   [[V_CMP_NE_U32_e64_:%[0-9]+]]:sreg_64 = V_CMP_NE_U32_e64 2, [[COPY1]], implicit $exec
-  ; GCN:   [[COPY4:%[0-9]+]]:sreg_64 = COPY $exec, implicit-def $exec
-  ; GCN:   [[S_AND_B64_1:%[0-9]+]]:sreg_64 = S_AND_B64 [[COPY4]], [[V_CMP_NE_U32_e64_]], implicit-def dead $scc
+  ; GCN:   [[S_AND_B64_1:%[0-9]+]]:sreg_64 = S_AND_B64 $exec, [[V_CMP_NE_U32_e64_]], implicit-def dead $scc
   ; GCN:   $exec = S_MOV_B64_term [[S_AND_B64_1]]
----------------
arsenm wrote:
> rampitec wrote:
> > I am not sure autogenerated test really tests anything, as there is no GCN-NEXT. The copy may easily remain and be untested.
> The important part is the number of s_or_b64
But how you can be sure about the number if there can be some others in between of the checks?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59778/new/

https://reviews.llvm.org/D59778