[PATCH] D59778: AMDGPU: Make exec mask optimzations more resistant to block splits

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:144
+
+    // TODO: Is this really necessary?
+    if (!MBB->isLayoutSuccessor(Succ))
----------------
rampitec wrote:
> Yes, in case block is only preceded bit itself. We do not generate this way, but I can write such IR manually. Anyway layout successor means there will be no branch.
It doesn't mean there's no branch. It still allows

S_CBRANCH
<no S_BRANCH>

<fallthrough block>.

If both used unconditional branches it shouldn't be any different


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59778/new/

https://reviews.llvm.org/D59778