[PATCH] D59766: [TargetLowering] findOptimalMemOpLowering. NFC.
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 25 09:21:56 PDT 2019
SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:165
+ unsigned DstAS, unsigned SrcAS,
+ SelectionDAG &DAG) const {
+ assert((SrcAlign == 0 || SrcAlign >= DstAlign) &&
----------------
It's not convenient to pass the DAG, because it's unavailable from TTI where I would like to call and reuse this findOptimalMemOpLowering function. But since the DAG is only used to pass the MachineFunction to getOptimalMemOpType, which only uses it to get the Function, I am going to change findOptimalMemOpLowering and getOptimalMemOpType to take a Function as their last argument.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59766/new/
https://reviews.llvm.org/D59766
More information about the llvm-commits
mailing list