[PATCH] D59763: [llvm-objcopy] - Strip sections before symbols.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht requested changes to this revision.
rupprecht added a comment.
This revision now requires changes to proceed.

Just a couple test changes, otherwise LG and thanks for fixing this bug!



================
Comment at: test/tools/llvm-objcopy/ELF/strip-all-relocations.test:14
+
+# RUN: llvm-objcopy --strip-symbol=bar -R .rela.text %t2
+# RUN: llvm-objdump --section-headers %t2 | FileCheck %s
----------------
As a sanity check that this test is configured correctly, you might also want to run "not llvm-objcopy --strip-symbol=bar %t2" and make sure it prints the right error


================
Comment at: test/tools/llvm-objcopy/ELF/strip-all-relocations.test:14
+
+# RUN: llvm-objcopy --strip-symbol=bar -R .rela.text %t2
+# RUN: llvm-objdump --section-headers %t2 | FileCheck %s
----------------
rupprecht wrote:
> As a sanity check that this test is configured correctly, you might also want to run "not llvm-objcopy --strip-symbol=bar %t2" and make sure it prints the right error
This is missing %t as the source, it should be "llvm-objcopy %t %t2". This is "copying" %t2 in place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59763/new/

https://reviews.llvm.org/D59763