[PATCH] D59687: [DebugInfo] Prologue inserter need to insert DW_OP_deref_size

[Markus Lavin via Phabricator via llvm-commits]

markus marked an inline comment as done.
markus added a comment.

I am a bit worried about the other `DW_OP_deref` used in the compiler and how they behave wrt big-endian targets when loading something that is smaller than the size of an address on the target machine. I do not have any concrete example of where it goes wrong but I have not actively looked for one either.

Do we all agree that using plain `DW_OP_deref` is potentially problematic?



================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:1156
+        const DIExpression *DIExpr = MI.getDebugExpression();
+        auto isImplicit = [](const DIExpression &Exp) {
+          if (Exp.isValid())
----------------
aprantl wrote:
> This would make more sense as a member function of DIExpression?
Agree. Will move it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59687/new/

https://reviews.llvm.org/D59687