[PATCH] D59763: [llvm-objcopy] - Strip sections before symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I think another interesting test might be `-N <sym> -R <relocation section referencing sym>`. I'm assuming that this fails currently, based on the --strip-all symptoms.



================
Comment at: test/tools/llvm-objcopy/ELF/strip-relocations.test:1
+# RUN: yaml2obj %s > %t
+
----------------
Probably worth renaming this test strip-all-relocations.test, since it's not specifically about stripping relocations.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-relocations.test:3
+
+## Check we are able to strip all symbols and relocatable information.
+
----------------
Add "at the same time" to the end of this comment, as that's the important bit (it would have been possible to strip the relocation sections first, then the symbols as a workaround before).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59763/new/

https://reviews.llvm.org/D59763