[PATCH] D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 03:58:33 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/tools/llvm-readobj/elf-versioninfo.test:11
+LLVM-VERDEF: Version symbols {
+LLVM-VERDEF-NEXT:   Section Name: .gnu.version (20)
+LLVM-VERDEF-NEXT:   Address: 0x24C
----------------
Higuoxing wrote:
> jhenderson wrote:
> > Maybe you should make one of the symbols in this section have a version > 0x7fff, e.g. 0xffff?
> This test file uses a pre-compiled object file, I want (replace this/add one test) using `yaml2obj` in next patch.
Right, of course.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59186/new/

https://reviews.llvm.org/D59186





More information about the llvm-commits mailing list