[PATCH] D59740: [WebAssembly] Don't analyze branches after CFGStackify

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 23 14:02:12 PDT 2019


arsenm added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrInfo.cpp:106-107
+  // If we're running after CFGStackify, we can't optimize further.
+  if (MFI.isCFGStackified())
+    return true;
+
----------------
I think this isn't what you want to do. analyzeBranch isn't really for turning off transformations. The verifier will stop catching useful cases with this


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59740/new/

https://reviews.llvm.org/D59740





More information about the llvm-commits mailing list