[PATCH] D59716: [ConstantRange] Add full() + empty() named constructors (NFC)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 23 05:55:31 PDT 2019


lebedev.ri added a comment.

Looks like a nice cleanup! The naming choice is a bit controversial i think.
Is it fully obvious that `full()`/`empty()` don't check that it's full/empty and return bool, but return new full/empty range?
Any more obvious choices? Or am i imagining this?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59716/new/

https://reviews.llvm.org/D59716





More information about the llvm-commits mailing list