[llvm] r356826 - Disable MachO TBD write tests for Windows.

Juergen Ributzka via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 22 17:03:24 PDT 2019


Author: ributzka
Date: Fri Mar 22 17:03:23 2019
New Revision: 356826

URL: http://llvm.org/viewvc/llvm-project?rev=356826&view=rev
Log:
Disable MachO TBD write tests for Windows.

The tests are failing on the windows bots. I am disabling them for now.
This is a followup to r356820.

Modified:
    llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp
    llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp

Modified: llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp?rev=356826&r1=356825&r2=356826&view=diff
==============================================================================
--- llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp (original)
+++ llvm/trunk/unittests/TextAPI/TextStubV1Tests.cpp Fri Mar 22 17:03:23 2019
@@ -149,6 +149,8 @@ TEST(TBDv1, ReadFile2) {
   EXPECT_EQ(0U, File->reexportedLibraries().size());
 }
 
+// Disable test for windows.
+#ifndef _WIN32
 TEST(TBDv1, WriteFile) {
   static const char tbd_v1_file3[] =
       "---\n"
@@ -215,6 +217,7 @@ TEST(TBDv1, Platform_macOS) {
   EXPECT_EQ(FileType::TBD_V1, File->getFileType());
   EXPECT_EQ(PlatformKind::macOS, File->getPlatform());
 }
+#endif // _WIN32
 
 TEST(TBDv1, Platform_iOS) {
   static const char tbd_v1_platform_ios[] = "---\n"

Modified: llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp?rev=356826&r1=356825&r2=356826&view=diff
==============================================================================
--- llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp (original)
+++ llvm/trunk/unittests/TextAPI/TextStubV2Tests.cpp Fri Mar 22 17:03:23 2019
@@ -173,6 +173,8 @@ TEST(TBDv2, ReadFile2) {
   EXPECT_EQ(0U, File->reexportedLibraries().size());
 }
 
+// Disable test for windows.
+#ifndef _WIN32
 TEST(TBDv2, WriteFile) {
   static const char tbd_v2_file3[] =
       "--- !tapi-tbd-v2\n"
@@ -225,6 +227,7 @@ TEST(TBDv2, WriteFile) {
   EXPECT_FALSE(Result);
   EXPECT_STREQ(tbd_v2_file3, Buffer.c_str());
 }
+#endif // _WIN32
 
 TEST(TBDv2, Platform_macOS) {
   static const char tbd_v1_platform_macos[] = "--- !tapi-tbd-v2\n"




More information about the llvm-commits mailing list