[PATCH] D59661: [GVN] Try to be more principled about non-integral pointers

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

I really like what you're trying to do here, but the actual change is problematic.  You're mixing non-functional refactoring with semantic change which makes this really hard to understand.  Please split this into at least two parts.  (I say at least because you appear to have some code motion changes which could be landed trivially without review as well.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59661/new/

https://reviews.llvm.org/D59661