[PATCH] D59717: AMDGPU: Ignore SRAM ECC feature when inlining

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 22 15:03:56 PDT 2019


arsenm added a comment.

In D59717#1440169 <https://reviews.llvm.org/D59717#1440169>, @rampitec wrote:

> In D59717#1440117 <https://reviews.llvm.org/D59717#1440117>, @arsenm wrote:
>
> > This isn't correct, this does impact codegen. This changes whether d16 instruction can be used
>
>
> But these instructions created after any inlining.


The features should be consistent with no knowledge of the function body. An ecc function calling a non-ecc function is potentially broken, so it shouldn’t be inlined


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59717/new/

https://reviews.llvm.org/D59717





More information about the llvm-commits mailing list