[PATCH] D59515: [llvm] Prevent duplicate files in debug line header in dwarf 5.

[Ali Tamur via Phabricator via llvm-commits]

tamur marked 3 inline comments as done.
tamur added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1034
+  else
+    return Prologue.FileNames[Index - 1];
 }
----------------
dblaikie wrote:
> Perhaps in v4 we could keep Index == array index, and leave FileNames[0] unused? (I guess then it might need a special case when being emitted to skip over FileNames[0]?)
I'd prefer not to change dwarf4 behavior as much as possible, if that's ok with you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59515/new/

https://reviews.llvm.org/D59515