[PATCH] D59653: [NFC] Add tests for ssubo X, C -> saddo X, -C

[Dan Robertson via Phabricator via llvm-commits]

dlrobertson added a comment.

In D59653#1438433 <https://reviews.llvm.org/D59653#1438433>, @nikic wrote:

> It would be good to also have test cases (for the ssubo->saddo canonicalization, not the nsw fold) where the vector constant argument of the ssubo has undef or is non-splat. This is one of those rare cases where we can easily support them, because the necessary machinery is already in place (see https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstCombineCalls.cpp#L2194).


Makes sense.

In D59653#1438673 <https://reviews.llvm.org/D59653#1438673>, @nikic wrote:

> Additionally we'll also want to test cases where we have i8 -128 on the RHS (with the usual variations, like vector with one element -128 but not others), as we can't do the canonicalization for that case.


Sounds good!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59653/new/

https://reviews.llvm.org/D59653