[PATCH] D57779: [SLP] Add support for throttling.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:841
+  /// Internal tree proposed to vectorized values use in that tree.
+  SmallDenseMap<Value*, UserList> InternalTreeUses;
+
----------------
Not formatted


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2458
+
+  if (ScalarizeAt == (VectorizableTree.size() - 1) || ScalarizeAt == 0)
+    return;
----------------
Hmm, will it work with the graph? Seems to me, it will work absolutely correctly only with the list and might not be quite correct even for tree. VectorizableTree is actually a linearized graph and the index is not connected anyhow with the tree/graph depth/height.
You need to nalyze each particular subgraph/subtree independently, and thus, cannot rely on the single index.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779