[PATCH] D59695: [llvm-objcopy] - Report SHT_GROUP sections with invalid alignment.
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 22 11:54:36 PDT 2019
rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.
> Since such group sections should not be met in reality (I think), I would suggest to ban them.
> This patch does that.
Given the code snippet you included in ELFSectionWriter, it sounds like even if they *are* met in reality, llvm-objcopy is already broken. Having a specific error instead of a cryptic misaligned write crash seems more useful.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59695/new/
https://reviews.llvm.org/D59695
More information about the llvm-commits
mailing list