[PATCH] D59594: [ELF] Change GOT*_FROM_END (relative to end(.got)) to GOTPLT* (start(.got.plt))

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D59594#1439028 <https://reviews.llvm.org/D59594#1439028>, @MaskRay wrote:

> This gives me more confidence..
>
>   ninja -C Release clang lld  # build lld with this change
>  
>   cmake -GNinja -H. -BGOT -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER=$HOME/llvm/Release/bin/clang++ -DCMAKE_C_COMPILER=$HOME/llvm/Release/bin/clang -DLLVM_ENABLE_LLD=On -DLLVM_INCLUDE_GO_TESTS=OFF -DLLVM_INCLUDE_DOCS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF -DBUILD_SHARED_LIBS=On
>   ninja -C GOT check-all  # all (llvm+clang+extra+lld+compiler-rt) passed
>


I've tested this patch on our internal code base and I don't find any issues.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59594/new/

https://reviews.llvm.org/D59594