[PATCH] D59333: ELF: Rename Configuration::Static to Bstatic. NFCI.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D59333#1432520 <https://reviews.llvm.org/D59333#1432520>, @grimar wrote:

> In D59333#1432442 <https://reviews.llvm.org/D59333#1432442>, @MaskRay wrote:
>
> > In D59333#1432433 <https://reviews.llvm.org/D59333#1432433>, @grimar wrote:
> >
> > > In D59333#1428331 <https://reviews.llvm.org/D59333#1428331>, @ruiu wrote:
> > >
> > > > Maybe we should also update the helptext of Bstatic? It currently says that "Do not link against shared libraries" which doesn't sound like it captures the exact meaning of the option.
> > >
> > >
> > > "Do not search for dynamic libraries when linking"?
> >
> >
> > Is it worth mentioning the positional behavior? "Do not search for shared libraries mentioned on the command line after the option"
>
>
> The default behavior can be restored with -Bdynamic, which makes the wording
>  "mentioned on the command line after the option" not so precise perhaps?
>  We do not mention the position for other positional options as far I can see too (like for `-as-needed` and `-whole-archive`).
>
> For `-whole-archive` we have just:
>  "Force load of all members in a static library."
>
> And then for `-no-whole-archive`:
>  "Restores the default behavior of loading archive members."
>
> Maybe use words "disable/enable", i.e change the `-Bstatic` to
>  "Disable the lookup of dynamic libraries when linking".
>
> and then `-Bdynamic` to something like
>  "Enable the lookup of dynamic libraries when linking (default)"?


SG

Regarding the description

> The name of this field is a little misleading, partly because it does not match the name of its command line flag. Rename it to match.

Does not match the name of the compiler option `-static`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59333/new/

https://reviews.llvm.org/D59333