[PATCH] D59649: [ELF] Improve error message for relocations to symbols defined in discarded sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: ELF/Relocations.cpp:684
+    StringRef Signature = File->getShtGroupSignature(ObjSections, ELFSec);
+    auto It = Symtab->ComdatGroups.find(CachedHashStringRef(Signature));
+    if (It != Symtab->ComdatGroups.end())
----------------
grimar wrote:
> Use `lookup`?
Thank you! I didn't know the useful `lookup`...


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59649/new/

https://reviews.llvm.org/D59649