[PATCH] D57779: [SLP] Add support for throttling.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 22 06:49:12 PDT 2019


dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2755
+    int ScalarizeAtSpillCost = 0;
+    for (unsigned I = VectorizableTree.size()-1; I > 0; I--) {
+      TreeEntry *Entry = &VectorizableTree[I];
----------------
ABataev wrote:
> 1. Unformatted.
> 2. Use `--I`;
> 3. Are you sure that the exit condition is correct? Maybe `>=`, since you start from `size()-1`?
>Are you sure that the exit condition is correct? Maybe >=, since you start from size()-1?
yes, We don't one to consider one entry vectorizon here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779





More information about the llvm-commits mailing list