[PATCH] D59691: [llvm-objcopy]Add coverage for --split-dwo and --output-format

Fri Mar 22 05:17:42 PDT 2019

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.

================
Comment at: test/tools/llvm-objcopy/ELF/cross-arch-headers.test:38
 # RUN: llvm-readobj --file-headers %t.elf32_i386_freebsd.o | FileCheck %s --check-prefixes=CHECK,I386,32,FREEBSD
+# RUN: llvm-readobj --file-headers %t.elf32_i386_freebsd.dwo | FileCheck %s --check-prefixes=CHECK,I386,32,FREEBSD

----------------
nit: grouping here is a bit broken.
(That is started before your patch, but since you do a massive change anyways, is it worth to regroup?)

I mean that at first it looks like all elf64 follows the elf32, but then FreeBSD breaks this rule.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59691/new/

https://reviews.llvm.org/D59691