[PATCH] D59515: Prevent duplicate files in debug line header in dwarf 5.
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 22 04:06:22 PDT 2019
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
A couple more style nits and LGTM.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1024
+ return FileIndex < Prologue.FileNames.size();
+ else
+ return FileIndex != 0 && FileIndex <= Prologue.FileNames.size();
----------------
No 'else' after a 'return'
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1033
+ return Prologue.FileNames[Index];
+ else
+ return Prologue.FileNames[Index - 1];
----------------
No 'else' after a 'return'
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59515/new/
https://reviews.llvm.org/D59515
More information about the llvm-commits
mailing list