[PATCH] D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used

Fri Mar 22 03:40:43 PDT 2019

grimar added inline comments.

================
Comment at: lld/test/ELF/Inputs/gc-sections-debuginfo-32.s:7
+.long .text
+
----------------
You do not need these 2 new input files I think.
Just inline the code like we often do in LLD (e.g. https://github.com/llvm-mirror/lld/blob/master/test/ELF/linkerscript/no-filename-spec.s)

================
Comment at: lld/test/ELF/gc-sections-debuginfo.s:34
+# CHECK-NEXT: SectionData (
+# CHECK64-NEXT:   0000: FEFFFFFF FFFFFFFF                    |
+# CHECK32-NEXT:   0000: FEFFFFFF                     |
----------------
Please remove the spaces after `...FFF` and `|` symbol, no need to test we print it here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59553/new/

https://reviews.llvm.org/D59553