[PATCH] D59645: [llvm-objcopy]Add support for *-freebsd output formats

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/ELFObjcopy.cpp:229
     DWOFile->Machine = Config.OutputArch.getValue().EMachine;
+    DWOFile->OSABI = Config.OutputArch.getValue().OSABI;
+  }
----------------
jhenderson wrote:
> grimar wrote:
> > Oh. Was this place tested? Seems not.
> Yeah, I noticed this when I was uploading this patch. I've got a note on my desk to look at adding a test for this section (the Machine line immediately above it is also untested). Given the block is already untested, are you happy for this to be tested in a separate patch, or would you prefer it being part of this one?
> Given the block is already untested, are you happy for this to be tested in a separate patch, or would you prefer it being part of this one?

I think it's fine to do in a separate patch then.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59645/new/

https://reviews.llvm.org/D59645