[PATCH] D59645: [llvm-objcopy]Add support for *-freebsd output formats

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D59645#1438161 <https://reviews.llvm.org/D59645#1438161>, @rupprecht wrote:

> In the method that actually sets the OSABI member [2], if the OSABI field is still ELFOSABI_NONE, it will change it to ELFOSABI_GNU if the object contains GNU symbols. Does this seem useful to do?


It does seem somewhat useful, but it looks like a different, only tangetially-related, behaviour, so I'll file a bug for that, especially as I imagine it will slow down the tool (it'll have to keep track of all symbols that are GNU symbols).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59645/new/

https://reviews.llvm.org/D59645