[PATCH] D59626: Add MachineDCE pass after RenameIndependentSubregs

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 11:08:51 PDT 2019


rampitec added a comment.

In D59626#1438258 <https://reviews.llvm.org/D59626#1438258>, @arsenm wrote:

> In D59626#1438255 <https://reviews.llvm.org/D59626#1438255>, @arsenm wrote:
>
> > I feel like we just keep spamming DCE runs to solve issues. Is there some reason it's difficult for RenameIndependentSubregs to clean up after itself?
>
>
> Also, I think making more passes to have to care about LiveIntervals should generally be avoided


It is not only RenameIndependentSubregs, detect dead lanes also just mark them dead. I guess the assumption was it will be later deadcoded. And that never happened.
Even if both passes will cleanup after themselves both will need to handle LIS anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59626/new/

https://reviews.llvm.org/D59626





More information about the llvm-commits mailing list