[PATCH] D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 14:17:28 PDT 2019


echristo added a comment.

In D59553#1437670 <https://reviews.llvm.org/D59553#1437670>, @probinson wrote:

> @jhenderson  and I did a prototype of DWARF-unit-per-function last year, and I was not favorably impressed by the numbers. But maybe he still has the actual data kicking around somewhere.  We did not solve all the issues to our satisfaction before we ran out of time.
>  I've also had chats with @bd1976llvm about fragmenting .debug_info per-function without wrapping everything in units; you get into requiring some section-order things but it saves the unit-per-function overhead.


This is pretty much what I was talking about. You definitely don't need to do it as units if you're just including the concrete function. FWIW this is what I was talking about in the dwarf meeting where we talked about bringing units back into debug_info :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59553/new/

https://reviews.llvm.org/D59553





More information about the llvm-commits mailing list