[PATCH] D59274: [WebAssembly] Add linker options to control feature checking

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Driver.cpp:351
+  } else {
+    Config->Features = llvm::Optional<std::vector<std::string>>();
+  }
----------------
Is this not the default for Optional types?  Can you remove this else block?


================
Comment at: lld/wasm/Writer.cpp:920
+      if (!TargetFeatures.count(Feature))
+        error(Twine("Target feature \"") + Feature + "\" is not allowed.");
+    }
----------------
Use single quotes around feature name to avoid escape chars?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59274/new/

https://reviews.llvm.org/D59274