[PATCH] D59653: [NFC] Add tests for ssubo X, C -> saddo X, -C

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 12:13:36 PDT 2019


nikic added a comment.

It would be good to also have test cases (for the ssubo->saddo canonicalization, not the nsw fold) where the vector constant argument of the ssubo has undef or is non-splat. This is one of those rare cases where we can easily support them, because the necessary machinery is already in place (see https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/InstCombine/InstCombineCalls.cpp#L2194).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59653/new/

https://reviews.llvm.org/D59653





More information about the llvm-commits mailing list