[PATCH] D59660: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 11:55:09 PDT 2019


delcypher created this revision.
delcypher added reviewers: kubamracek, yln.
Herald added a reviewer: serge-sans-paille.
Herald added projects: Sanitizers, LLVM.
Herald added a subscriber: Sanitizers.
delcypher removed a reviewer: serge-sans-paille.
Herald added a reviewer: serge-sans-paille.

To make this test pass it was necesary to change `iossim_run.py` to
propagate the `ASAN_ACTIVATION_OPTIONS` environment variable into the
testing environment.

rdar://problem/49114807


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D59660

Files:
  compiler-rt/test/asan/TestCases/Posix/start-deactivated.cc
  compiler-rt/test/sanitizer_common/ios_commands/iossim_run.py


Index: compiler-rt/test/sanitizer_common/ios_commands/iossim_run.py
===================================================================
--- compiler-rt/test/sanitizer_common/ios_commands/iossim_run.py
+++ compiler-rt/test/sanitizer_common/ios_commands/iossim_run.py
@@ -8,7 +8,7 @@
 
 device_id = os.environ["SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER"]
 
-for e in ["ASAN_OPTIONS", "TSAN_OPTIONS", "UBSAN_OPTIONS", "APPLE_ASAN_INIT_FOR_DLOPEN"]:
+for e in ["ASAN_OPTIONS", "TSAN_OPTIONS", "UBSAN_OPTIONS", "APPLE_ASAN_INIT_FOR_DLOPEN", "ASAN_ACTIVATION_OPTIONS"]:
   if e in os.environ:
     os.environ["SIMCTL_CHILD_" + e] = os.environ[e]
 
Index: compiler-rt/test/asan/TestCases/Posix/start-deactivated.cc
===================================================================
--- compiler-rt/test/asan/TestCases/Posix/start-deactivated.cc
+++ compiler-rt/test/asan/TestCases/Posix/start-deactivated.cc
@@ -18,7 +18,6 @@
 // RUN: %env_asan_opts=start_deactivated=1 \
 // RUN:   ASAN_ACTIVATION_OPTIONS=help=1,handle_segv=0,verbosity=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORTED
 
-// UNSUPPORTED: ios
 
 // END.
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59660.191757.patch
Type: text/x-patch
Size: 1133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190321/5766d509/attachment.bin>


More information about the llvm-commits mailing list