[PATCH] D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify

Thu Mar 21 10:03:34 PDT 2019

aheejin marked 2 inline comments as done.
aheejin added inline comments.

================
Comment at: lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp:834
+  // there can be multiple cases:
+  // 1. We have -wasm-disable-explicit-locals set.
+  // 2. We don't have -wasm-disable-explicit-locals set.
----------------
dschuff wrote:
> It seems unfortunate that we have to care about whether explicit locals is turned on. Is that just because this pass runs after `createWebAssemblyExplicitLocals`? Does the order matter? e.g. would it be simpler to run it after CfgStackify? Or, could we just run it again if this pass changes anything?
Actually I don't think the order matters. Thanks for the idea. Created D59652.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48345/new/

https://reviews.llvm.org/D48345