[PATCH] D59539: [llvm-exegesis] Option to lobotomize dbscan (PR40880)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 10:03:31 PDT 2019


lebedev.ri added a comment.

In D59539#1436216 <https://reviews.llvm.org/D59539#1436216>, @lebedev.ri wrote:

>


I'm not saying that this *is* The solution, but i do believe the problem exists,
and i'm not sure what other approaches are there to solve it..

There is another bug there, i suppose, we really should sort the measurements we loaded.
E.g. because now given measurement `0.5`, `1.0`, `1.5`, if they are in that order then
you get (i think, didn't check) two clusters: `0.5`+`1.0` and `1.5` (correct).
But if they are ``1.0`, 0.5`, `1.5`, then that will be a single cluster..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59539/new/

https://reviews.llvm.org/D59539





More information about the llvm-commits mailing list