[PATCH] D59649: [ELF] Improve error message for relocations to symbols defined in discarded COMDAT

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: ruiu, smeenai.
Herald added subscribers: llvm-commits, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This is PR41133. Rather than report "undefined symbol: ", print more
informative error message: the section group signature, the object file
with the discarded section, and the object file with the prevailing
definition.

This is useful to track down some ODR issues.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D59649

Files:
  ELF/InputFiles.cpp
  ELF/InputFiles.h
  ELF/Relocations.cpp
  ELF/SymbolTable.cpp
  ELF/SymbolTable.h
  test/ELF/Inputs/comdat-discarded-error.s
  test/ELF/comdat-discarded-error.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59649.191716.patch
Type: text/x-patch
Size: 10730 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190321/d60972b8/attachment.bin>