[PATCH] D59514: [PGO] Profile guided code size optimization.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 09:13:51 PDT 2019


davidxl added a comment.

Look fine in general. Easwaran can help with review of pass pipeline changes



================
Comment at: lib/Transforms/Scalar/LoopLoadElimination.cpp:536
     if (!Checks.empty() || !LAI.getPSE().getUnionPredicate().isAlwaysTrue()) {
-      if (L->getHeader()->getParent()->optForSize()) {
+      bool OptForSize =
+          L->getHeader()->getParent()->optForSize() ||
----------------
auto *HeaderBB = L->getHeader()->getParent();
bool OptForSize = HeaderBB->optForSize() || (PSI && BFI && PSI->shouldOptimizeForSize(HeaderBB));


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59514/new/

https://reviews.llvm.org/D59514





More information about the llvm-commits mailing list