[PATCH] D59638: [llvm-objcopy] - Implement replaceSectionReferences for GroupSection class.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D59638#1437787 <https://reviews.llvm.org/D59638#1437787>, @jhenderson wrote:

> Hmm, I suppose for strict correctness, you should also check if the associated symbol table needs updating too.


Could you elaborate please what you have in mind? We currently already update all the symbols in the symbol table.

Spec says (https://docs.oracle.com/cd/E19683-01/816-1386/chapter7-26/index.html):
"The name of a symbol from one of the containing object's symbol tables provides a signature for the section group."
In the test, I check that the group signature is still `groupname` both after compression and decompression,
i.e. I think I already check that nothing is broken here. Am I missing something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59638/new/

https://reviews.llvm.org/D59638