[PATCH] D59638: [llvm-objcopy] - Implement replaceSectionReferences for GroupSection class.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good apart from a few comments.



================
Comment at: test/tools/llvm-objcopy/ELF/compress-debug-sections-groups.test:5
+
+## In this test, we check how tool handles compression/decompression
+## of debug section included in a COMDAT group.
----------------
tool -> llvm-objcopy

(let's be explicit)


================
Comment at: test/tools/llvm-objcopy/ELF/compress-debug-sections-groups.test:6
+## In this test, we check how tool handles compression/decompression
+## of debug section included in a COMDAT group.
+
----------------
section -> sections


================
Comment at: test/tools/llvm-objcopy/ELF/compress-debug-sections-groups.test:8
+
+## Check how we compress debug section.
+# RUN: llvm-objcopy --compress-debug-sections %t.o %t-compressed.o
----------------
I'd tweak this and the below comments to the following, as it sounds more natural:

"Check compression of debug sections." (or decompression)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59638/new/

https://reviews.llvm.org/D59638