[PATCH] D58404: [clang-format] Add basic support for formatting C# files
MyDeveloperDay via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 21 03:51:56 PDT 2019
MyDeveloperDay added inline comments.
================
Comment at: clang/unittests/Format/FormatTestCSharp.cpp:19
+
+class FormatTestCSharp : public ::testing::Test {
+protected:
----------------
klimek wrote:
> If everything's static, you don't need a test fixture at all, you can just make it plain functions and use TEST() instead of TEST_F().
I was actually just following the existing style of the other tests, but looking into what you said it seems we could almost do this in the other tests too.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58404/new/
https://reviews.llvm.org/D58404
More information about the llvm-commits
mailing list