[PATCH] D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

LGTM, with one last comment. Please wait for @rupprecht to confirm that he is happy.



================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4524
+  const uint8_t *VersymBuf = (const uint8_t *)Obj->base() + Sec->sh_offset;
+  auto *Dumper = this->dumper();
+  StringRef StrTable = Dumper->getDynamicStringTable();
----------------
`ELFDumper<ELFT>` not `auto`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59186/new/

https://reviews.llvm.org/D59186