[PATCH] D58404: [clang-format] Add basic support for formatting C# files

[Manuel Klimek via Phabricator via llvm-commits]

klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.

LG. This looks pretty sharp (scnr).



================
Comment at: clang/lib/Format/FormatTokenLexer.cpp:177
+    if (Dollar->TokenText == "$") {
+      // this looks like $@"aaaaa" so we need to combine all 3
+      Dollar->Tok.setKind(tok::string_literal);
----------------
Tiny nit: please try to keep comments formatted as sentence (upper-case first letter, "." in the end).


================
Comment at: clang/unittests/Format/FormatTestCSharp.cpp:19
+
+class FormatTestCSharp : public ::testing::Test {
+protected:
----------------
If everything's static, you don't need a test fixture at all, you can just make it plain functions and use TEST() instead of TEST_F().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58404/new/

https://reviews.llvm.org/D58404