[PATCH] D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D59553#1436647 <https://reviews.llvm.org/D59553#1436647>, @dblaikie wrote:

> Looking at all the cases where addresses to sections that aren't allocated (& this happens not just in gc-sections, but also with inline functions (the DWARF for one copy of an inline function can't point to another copy, so its addresses become zero currently, etc) which is a more broadly applicable problem (though I suppose without gc-sections a CU's address range can't be empty, because it can't consist of only inline functions - but it does apply to the high/low pc of the subprogram DIE at least))


Worth noting that a CU could consist of just COMDAT functions though, so we still need to be aware of it. Also COMDATs mean that whatever we do here is beneficial even without --gc-sections.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59553/new/

https://reviews.llvm.org/D59553