[PATCH] D57493: [RISCV] Put data smaller than eight bytes to small data section
Shiva Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 20 23:32:49 PDT 2019
shiva0217 marked an inline comment as done.
shiva0217 added inline comments.
================
Comment at: lib/Target/RISCV/RISCVTargetObjectFile.cpp:103
+ if (Key == "SmallDataLimit") {
+ SSThreshold = mdconst::extract<ConstantInt>(MFE.Val)->getZExtValue();
+ break;
----------------
apazos wrote:
> Here the flag value is overwritten by the module setting, so how can we use the flag?
We probably could remove riscv-ssection-threshold flag because front end won't pass the flag and emit the threshold by module flag.
Thanks for the catch.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57493/new/
https://reviews.llvm.org/D57493
More information about the llvm-commits
mailing list