[PATCH] D59530: [LLD][COFF] Fix /linkrepro with options that take a filename or path

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 17:10:18 PDT 2019


ruiu added inline comments.


================
Comment at: COFF/Driver.cpp:542
+    case OPT_out:
+      Val = sys::path::filename(Arg->getValue());
+      LLVM_FALLTHROUGH;
----------------
Let's just write out what you want here, instead of adding a variable and a new helper function.

  OS << Arg->getSpelling() << ":" << sys::path::filename(Arg->getValue()) << "\n";


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59530/new/

https://reviews.llvm.org/D59530





More information about the llvm-commits mailing list