[PATCH] D59531: [ELF] Produce multiple PT_NOTE segments as needed

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/ELF/Writer.cpp:2038-2039
 
-  // Create one PT_NOTE per a group of contiguous .note sections.
-  PhdrEntry *Note = nullptr;
-  for (OutputSection *Sec : OutputSections) {
-    if (Sec->Type == SHT_NOTE && (Sec->Flags & SHF_ALLOC)) {
-      if (!Note || Sec->LMAExpr)
-        Note = AddHdr(PT_NOTE, PF_R);
-      Note->add(Sec);
-    } else {
-      Note = nullptr;
-    }
-  }
+  // Create one PT_NOTE per a group of contiguous .note sections with
+  // alignment such that notes can be parsed in order.
+  for (OutputSection *Sec : OutputSections)
----------------
This comment is no longer accurate.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59531/new/

https://reviews.llvm.org/D59531