[PATCH] D59574: Fix Mach-O bind and rebase validation errors in libObject

[Michael Trent via Phabricator via llvm-commits]

mtrent marked an inline comment as done.
mtrent added inline comments.


================
Comment at: lib/Object/MachOObjectFile.cpp:3993
+        continue;
+      if (SI.OffsetInSegment <= Start && Start < SI.OffsetInSegment + SI.Size) {
+        if (End <= SI.OffsetInSegment + SI.Size) {
----------------
pete wrote:
> Can you add some ()'s?  eg:
> 
> if ((SI.OffsetInSegment <= Start) && (Start < (SI.OffsetInSegment + SI.Size)))
> 
> Otherwise LGTM.  And sorry if this makes 80 cols hard to achieve!
Will do


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59574/new/

https://reviews.llvm.org/D59574