[PATCH] D59548: [Sanitizer] Add interceptor for wctomb

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 13:12:59 PDT 2019


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:3549
+  // its metadata. See
+  // https://github.com/google/sanitizers/issues/321.
+  int res = REAL(wctomb)(dest, src);
----------------
vitalybuka wrote:
> I don't like that we add another FIXME here
> Could you try to make something similar to https://reviews.llvm.org/rL211153
> 
could you avoid heap here?
with check local_dest[64] or any value large enough



Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59548/new/

https://reviews.llvm.org/D59548





More information about the llvm-commits mailing list