[PATCH] D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state.
George Burgess IV via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 20 11:20:57 PDT 2019
george.burgess.iv added a comment.
MSSA bits LGTM (to reiterate, as do the CFLAA bits). Leaving the rest of the patch to the other reviewers
Thanks!
================
Comment at: lib/Analysis/MemorySSA.cpp:1176
+ this->AA = AA;
+ getWalker();
}
----------------
Please add a comment saying that we're ensuring the walker exists because [...]
Might also be good to refactor `getWalker()` to remove the creation logic/checks, since creation is now always done here. Probably better done as a later CL, though.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59315/new/
https://reviews.llvm.org/D59315
More information about the llvm-commits
mailing list