[PATCH] D59597: [scudo][standalone] Add flags & related parsers

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: lib/scudo/standalone/flags_parser.cc:159
+FlagParser::FlagParser() : NumberOfFlags(0), Buffer(nullptr), Pos(0) {
+  Flags = reinterpret_cast<Flag *>(Alloc.allocate(sizeof(Flag) * MaxFlags));
+}
----------------
Could we just have `Flags` be a static array?


================
Comment at: lib/scudo/standalone/flags_parser.h:26
+  void operator delete(void *, size_t) {}
+};
+
----------------
Do we need inheritance for Scudo?


================
Comment at: lib/scudo/standalone/flags_parser.h:36
+  void operator delete(void *) {}
+  void operator delete(void *, size_t) {}
+  ~FlagHandler() final = default;
----------------
Why do we need `operator delete`?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59597/new/

https://reviews.llvm.org/D59597